Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Please consider implementing Marlin's REDUCED_ACCURACY_WARNING on the CR-6 SE display #73

Closed
Thinkersbluff opened this issue Dec 12, 2020 · 5 comments
Labels
area:dwin-interop Area - DWIN interop t:enhancement New feature or request

Comments

@Thinkersbluff
Copy link

When my Ender 3 needs to be homed, Marlin 4.0.7.2 alternately displays "??" and "0.0" or "??", Blank, "0.0", (whatever it takes to make it look as if the displayed values are flashing)

Since Marlin will happily drive an axis into the stops and keep going, when Marlin "thinks" the axis is currently at a position which it is not, it would be a kindness to remind the user when Marlin really has no idea where the axes presently are.
e.g.:

  • From when the machine is first powered up, until it is first homed;
  • Whenever "Disable Steppers" is pressed;
  • Whenever the non-zero DEFAULT_STEPPER_DEACTIVE_TIME has been reached (at least for those axes set with disable "TRUE".

I see that Configuration.h actually has a special setting to disable that flashing warning, so it may be a consideration to design this feature in a way that could also be overridden with ; this setting, though I could live without it.
"// Turn off the display blinking that warns about possible accuracy reduction
//#define DISABLE_REDUCED_ACCURACY_WARNING"

@Thinkersbluff Thinkersbluff changed the title [FR] Please consider implementing Marlin's REDUCED_ACCURACY_WARNING on this display [FR] Please consider implementing Marlin's REDUCED_ACCURACY_WARNING on the CR-6 SE display Dec 12, 2020
@Sebazzz
Copy link
Collaborator

Sebazzz commented Dec 13, 2020

It is not very easy to do due to the way the DWIN touch screen is configured with the numeric inputs. Also chiming in @grobux here.

I don't think the numerical inputs have any native way to display an unknown position. However, using stack pointers we might be able to change the color.

@InsanityAutomation
Copy link

Only thing I can think of to do easily is flash 999 / value based on the same blink code from the ultralcd 920 code

@Thinkersbluff
Copy link
Author

If we are not able to mimic the LCD display's behaviour (i.e. flashing "??") are there other techniques used to caution users of TFT displays, when the displayed positional data may not be correct?

If you can change colour, for instance, changing the displayed value to the same colour as the background would serve to blank their display. Toggling colours could serve to make the values seem to flash. Is the difficulty a matter of knowing when to give this feedback or just how to present a particular type of cautionary message?

@Sebazzz Sebazzz added the t:enhancement New feature or request label Dec 23, 2020
@Sebazzz
Copy link
Collaborator

Sebazzz commented Dec 24, 2020

Implemented now. Unknown axis are shown as red, and when homed back to white.

@Sebazzz
Copy link
Collaborator

Sebazzz commented Dec 26, 2020

Closing because this is implemented and ready for release in CF5 beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dwin-interop Area - DWIN interop t:enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants