Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button styling doesn't work on OS X #144

Open
qiemem opened this issue Feb 11, 2015 · 16 comments
Open

Button styling doesn't work on OS X #144

qiemem opened this issue Feb 11, 2015 · 16 comments

Comments

@qiemem
Copy link
Contributor

qiemem commented Feb 11, 2015

Buttons look like this no matter what:

image

xw:set-color does not appear to have an effect.

@nicolaspayette
Copy link
Member

@stevebhall reports that, with the 6.0.2 version:

The xw ‘buttons', which use to have, by default, this beautiful gray shading on them, now appear solid white. And I can’t seem to set them to any other color even when I explicitly ‘set’ the color. (my other xw widgets seem to be colored fine).

He doesn't confirm being on OS X, but I think that's the only platform where buttons have a "beautiful gray shading", so I'm just going to assume. :-) I also suspect that the change from "no color" to "no shading at all" might be a consequence of the switch to the Glass L&F in NetLogo 6.x (NetLogo/NetLogo#1034).

It seems possible that calling setBorderPainted(false) could help. The problem for me, as always, is that I don't have a Mac handy to try it on, so I'll need testers when I get around to it.

@stevebhall
Copy link

Yes Nicola I am describing an issue that occurs on OS X. I'm happy to test out on possible fix and report back here with the results. (Btw, with my model, the xw buttons 'do' display gray on my Windows machine.)

@nicolaspayette
Copy link
Member

It's a shot in the dark, but I'm trying setBorderPainted(false) in 77e9c5a. I uploaded a release if anyone (@stevebhall, @qiemem) want to give it a spin:

https://github.com/CRESS-Surrey/eXtraWidgets/releases/tag/v2.0.0-BETA3

@stevebhall
Copy link

stevebhall commented Dec 18, 2017 via email

@stevebhall
Copy link

stevebhall commented Sep 10, 2018 via email

@nicolaspayette
Copy link
Member

Hi Steve! Glad to learn that you are back at it! I'll try to take a look at the error shortly.

When you say:

We got it working fine in NetLogo 6.0.2

Did you mean that you somehow got the button styling to work, or just that xw was working OK in general?

@stevebhall
Copy link

stevebhall commented Sep 13, 2018 via email

@stevebhall
Copy link

stevebhall commented Oct 23, 2018 via email

@nicolaspayette
Copy link
Member

nicolaspayette commented Oct 24, 2018 via email

@stevebhall
Copy link

stevebhall commented Oct 24, 2018 via email

nicolaspayette added a commit that referenced this issue Oct 29, 2018
@nicolaspayette
Copy link
Member

@stevebhall, I have pushed a new release that should solve the java.lang.NoSuchMethodError exception:

https://github.com/CRESS-Surrey/eXtraWidgets/releases/tag/2.0.0-BETA4

Let me know if it does the trick for you.

@stevebhall
Copy link

stevebhall commented Oct 29, 2018 via email

@stevebhall
Copy link

stevebhall commented Oct 29, 2018 via email

@stevebhall
Copy link

stevebhall commented Oct 30, 2018 via email

@nicolaspayette
Copy link
Member

See image below: Notice the ‘buttons’ under the ‘User Specification of …’ label.

I see no image. It could be because you're sending it through email instead of using the GitHub web interface. Do you think you could log in to GitHub and post it here directly? I wouldn't mind also seeing an image where the button outline was working if you still have one around.

I'd really like to get this fixed but my problem, as ever, is that I don't have a Mac to test it on. As much I appreciate your help in testing, the turn around time makes this somewhat laborious.

I'm actually starting a new job tomorrow. It means that xw won't be at the top of my priority list in the immediate future, but it could also mean that there might be a Mac lying around for me to test on. I'll keep you updated, in any case...

@stevebhall
Copy link

Hi Nicolas,
Here's what these buttons look like in the current Mac 6.04 version.
screen image

And best of fortunes with the new job!
Steve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants