-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add names to omp critical statements #486
Conversation
Hi @JanNiklasB Here, is a reference to the IBM description of the omp critical statement (IBM omp critical). |
src/module/ParticleCollector.cpp
Outdated
@@ -21,7 +21,7 @@ ParticleCollector::ParticleCollector(const std::size_t nBuffer, const bool clone | |||
} | |||
|
|||
void ParticleCollector::process(Candidate *c) const { | |||
#pragma omp critical | |||
#pragma omp critical(ModifiyContainer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, is a typo
src/module/HDF5Output.cpp
Outdated
@@ -248,7 +248,7 @@ void HDF5Output::close() { | |||
} | |||
|
|||
void HDF5Output::process(Candidate* candidate) const { | |||
#pragma omp critical | |||
#pragma omp critical(HDF5Output_access_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there is no other critical statement HDF output module, I would just go for "HDFOutput".
small typo and HDF5Output_access_file to HDFOutput
Hey, |
Hi @JanNiklasB |
Dear All,
with this pull request I want to add names to various
#pragma omp critical
statements.If such a statement has no name, it blocks every other critical statement with no name, which may cause an increase in runtime.
For example, a shell output should only block other shell outputs and not file outputs.
Furthermore, if not accessed through a python script but directly through c++, critical statements from the users files may also block critical statements in CRPropa.