-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugins): build_search_result end_date preprocessing #1304
Conversation
Test Results 4 files ± 0 4 suites ±0 6m 24s ⏱️ +21s Results for commit 42b2ce8. ± Comparison against base commit 1948645. This pull request skips 1 test.
|
Code Coverage (Ubuntu)
Diff against develop
Results for commit: 42b2ce8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Code Coverage (Windows)
Diff against develop
Results for commit: 42b2ce8 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
When
end_date_excluded
was set tofalse
, which is the case forcop_cds
andcop_ads
, invalid requests (end_date < start_date
) were sent to the provider when the user entered the same start and end date.Also, when the user entered only a date and not a datetime, unexpected results were returned because the end date was reduced by one.
With this fix, the end date is only reduced by one when the user enters a datetime with
00:00:00
. If only dates are given by the user, they are kept as they are.