fix(plugins): remove default queryables form value #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 4 files ±0 4 suites ±0 6m 34s ⏱️ -1s Results for commit 04a088c. ± Comparison against base commit b247f5c. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
Code Coverage (Ubuntu)Diff against developResults for commit: 04a088c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
|
Code Coverage (Windows)Diff against developResults for commit: 04a088c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
anesson-cs
force-pushed
the
default-queryables-form-value-deletion
branch
3 times, most recently
from
93182d0 to
1eb05e4
Compare
alambare
reviewed
Jan 24, 2025
anesson-cs
force-pushed
the
default-queryables-form-value-deletion
branch
from
1eb05e4 to
19d9e27
Compare
sbrunato
approved these changes
Feb 3, 2025
for now the check was only on default eodag configuration and constraints file of the provider
'fetch_data()' must have been exposed to use it correctly in the test
remove 'fetch_data()' method and apply directly 'lru_cache()' on the result of '_fetch_data()'
sbrunato
force-pushed
the
default-queryables-form-value-deletion
branch
from
19d9e27 to
04a088c
Compare
sbrunato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1450
When a queryable is called with an empty value (
"",None,[], etc.) indag.list_queryables(), the returned default value of this queryable must be cleared in order to let other queryables depending on it list all their available values. Now, no default value is returned and the queryable appears as required.Moreover, if a queryable was called in
dag.list_queryables()while it was neither a default value of the provider configuration nor in the provider constraints file but it was in the provider queryables form, an error was raised. This is possible now.fetch_data()method has been exposed instead of being initialized inECMWFSearchclass initialization to make the code cleaner and allow the mock of this method in tests.