Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug and improve test #183

Merged
merged 3 commits into from
Apr 10, 2019
Merged

Fix bug and improve test #183

merged 3 commits into from
Apr 10, 2019

Conversation

jtankw3
Copy link

@jtankw3 jtankw3 commented Apr 10, 2019

Fix bug in sort command

@jtankw3 jtankw3 added the v1.4 For v1.4 project milestone label Apr 10, 2019
@jtankw3 jtankw3 added this to the v1.4 milestone Apr 10, 2019
JonathanLeeWH
JonathanLeeWH approved these changes Apr 10, 2019
View reviewed changes
Copy link

@JonathanLeeWH JonathanLeeWH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job improving the test cases and fixing the bugs.

@JonathanLeeWH JonathanLeeWH merged commit ca6ca5a into CS2103-AY1819S2-T12-3:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanLeeWH JonathanLeeWH JonathanLeeWH approved these changes

Assignees
No one assigned
Labels
v1.4 For v1.4 project milestone
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@jtankw3 @JonathanLeeWH