Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update history page styles #101

Merged
merged 11 commits into from
Nov 13, 2024
Merged

Update history page styles #101

merged 11 commits into from
Nov 13, 2024

Conversation

McNaBry
Copy link

@McNaBry McNaBry commented Nov 13, 2024

Description

  • Move history out of account as parent div being flex/grid affects table style
  • Adjust width of side panel to be maximum 90% of screen width
  • Update styles of readonly editor

Checklist

  • I have updated documentation
  • All tests passing

Screenshots (if applicable)

* Move history out of account as parent div being flex/grid affects table style
* Adjust width of side panel to be maximum 90% of screen width
* Update styles of readonly editor
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you make the panel scrollable too?

frontend/src/app/history/history.component.html Outdated Show resolved Hide resolved
samuelim01 and others added 2 commits November 14, 2024 00:59
Co-authored-by: samuelim01 <61283948+samuelim01@users.noreply.github.com>
@McNaBry McNaBry requested a review from samuelim01 November 13, 2024 17:50
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for all your work

@McNaBry McNaBry merged commit 0c24387 into main Nov 13, 2024
6 checks passed
@McNaBry McNaBry deleted the fix-history branch November 13, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants