Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure codebase is production-ready #68

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Ensure codebase is production-ready #68

merged 6 commits into from
Nov 1, 2024

Conversation

samuelim01
Copy link

@samuelim01 samuelim01 commented Oct 30, 2024

Description

Create production-specific environment variables and modify backend services to be accessible on production.

Closes #24 and #25.

Checklist

  • I have updated documentation
  • All tests passing

Screenshots (if applicable)

@samuelim01 samuelim01 added this to the Milestone 6 milestone Oct 30, 2024
@samuelim01 samuelim01 requested a review from McNaBry October 30, 2024 18:10
@samuelim01 samuelim01 self-assigned this Oct 30, 2024
Base automatically changed from question-consumer to collab-page October 31, 2024 05:44
@samuelim01 samuelim01 changed the base branch from collab-page to main October 31, 2024 06:51
Make use of angular environments to ensure it serves the correct URLs on
production.
AWS load balancers are unable to trim off path (/api/server). Let's update the services themselves to contain these path prefixes.
Copy link

@McNaBry McNaBry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelim01 samuelim01 merged commit 097b6b7 into main Nov 1, 2024
5 checks passed
@samuelim01 samuelim01 deleted the production-ready branch November 1, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy the app on a production system
2 participants