Collab enhancement + Chat + Homepage #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the change, the content of the components spill over when it's too long. Now, it should be containted within the boxes even if the content of each component is long (cherry picked from commit 6aa266b)
(cherry picked from commit fbb31e7)
- Basic HTML and CSS for Chat - Basic Functionality for Chat (cherry picked from commit 8e153cf)
(cherry picked from commit a5a23c8)
(cherry picked from commit 849c37f)
Previously, the language selected would disappear if you refresh the page. Now, it's able to pick up the last language selected. (cherry picked from commit e639b21)
(cherry picked from commit 951077c)
- Update HTML and CSS for Chat - Update functionality to include timestamp (cherry picked from commit 014b85b)
(cherry picked from commit df9690a)
The previous commit introduced a bug where the editor's content is duplicated upon refresh. (cherry picked from commit d482a65)
(cherry picked from commit 82143f3)
Moved websocket and ydoc init to collab component. This lets the ydoc to be shared to chat component without affecting the layout. Plus, it makes more sense that collab handles all this instead of the editor component (cherry picked from commit 0329971)
(cherry picked from commit 2da56a9)
Fixed the styling issues introduced by chatbox component (cherry picked from commit 05d4799)
After the change, the content of the components spill over when it's too long. Now, it should be containted within the boxes even if the content of each component is long (cherry picked from commit f959fec)
(cherry picked from commit e4dfed2)
(cherry picked from commit db98a1d)
(cherry picked from commit 8672b34)
Previously, the language selected would disappear if you refresh the page. Now, it's able to pick up the last language selected. (cherry picked from commit 49c6dd2)
(cherry picked from commit 2534960)
The previous commit introduced a bug where the editor's content is duplicated upon refresh. (cherry picked from commit 5aec692)
(cherry picked from commit 2ff3ac0)
(cherry picked from commit c6e6432)
- Added Mute/Unmute Functionality (cherry picked from commit 807485f)
- collaboration.component.ts: Change from user_id to access token - chat-box.component.ts: Change functionality such that user can`t see what the other user type during the muted period, even after he/she unmute (cherry picked from commit e43f6bc)
- roomRoutes: Update routes - roomController: Add method to get room details by user - mongoDbService: Update findRoomsByUserId method (cherry picked from commit c8e5bb8)
roomController: Add Users In Room Details Retrieved for method getRoomsByUserIdandStatusController (cherry picked from commit 92fdb51)
(cherry picked from commit e6cddff)
- Allow retrieval of active room sessions - Add routing for rejoining room - Add routing for going to match page (cherry picked from commit 0d02d28)
(cherry picked from commit bf6dd5e)
Added condition for isForfeited
limcaaarl
added
nice-to-have
This was
linked to
issues
Nov 2, 2024
Closed
Closed
Closed
Closed
…S1/cs3219-ay2425s1-project-g03 into collab-enhancement * 'collab-enhancement' of https://github.com/CS3219-AY2425S1/cs3219-ay2425s1-project-g03: Fix linting Update budget
samuelim01
approved these changes
Nov 2, 2024
frontend/public/pair-programming.png
Outdated
There was a problem hiding this comment.
I'm getting this warning:
core.mjs:33117 NG0913: An image with src http://localhost:4200/pair-programming.png has intrinsic file dimensions much larger than its rendered size. This can negatively impact application loading performance. For more information about addressing or disabling this warning, see https://angular.dev/errors/NG0913. Find more at https://angular.dev/errors/NG0913
There was a problem hiding this comment.
Seems to be an issue that happens when the image size is > than screen size. Got it fixed by adding breakpoints.
There was a problem hiding this comment.
@limcaaarl Apparently Angular can generate the srcset automatically if we use ngSrc instead of src not sure if you wanna try that out: https://angular.dev/errors/NG0913#ways-to-fix-oversized-images
- Change the API for getting rooms details using isForfeit and roomStatus - Change the room routes - Change the client way to call the updated API - Update README.md
- Reduce padding to give more content space
- Removed frontend frameworks and data representation languages - Made the button for editor slightly smaller to match chat, and fix the spacing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Screenshots (if applicable)