Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Fix on the Collaboration Service #86

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Minor Fix on the Collaboration Service #86

merged 3 commits into from
Nov 8, 2024

Conversation

KhoonSun47
Copy link

@KhoonSun47 KhoonSun47 commented Nov 8, 2024 •
edited
Loading

Description

  • Fix the part where the room is initialised as api/collaboration/room_id to only room_id
  • Added a guard clause to prevent the user from accessing the room if the YJS docs is not present (check using room_id since the YJS docs collection name is the room_id itself)
  • Remove the ENV=PROD inside the env sample (I think we are using the NODE_ENV rather than ENV)

Checklist

  • I have updated documentation
  • All tests passing

Screenshots (if applicable)

photo_2024-11-08 15 35 02

@KhoonSun47
Minor Fix on the Collaboration Service Database
42d4992 
- Fix the part where the room is initialised as api/collaboration/room_id
to only room_id
@KhoonSun47 KhoonSun47 requested a review from limcaaarl November 8, 2024 07:38
@KhoonSun47 KhoonSun47 self-assigned this Nov 8, 2024
@KhoonSun47 KhoonSun47 changed the title Minor Fix on the Collaboration Service Database Minor Fix on the Collaboration Service Nov 8, 2024
@KhoonSun47
Minor Fix to Collaboration Service Based On Comments
1b9351c 
- Remove guard clause
- Change the way of handling the authorise under webSocketService
@KhoonSun47 KhoonSun47 requested a review from samuelim01 November 8, 2024 09:07
samuelim01
samuelim01 approved these changes Nov 8, 2024
View reviewed changes
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhoonSun47 KhoonSun47 merged commit 9ff60da into main Nov 8, 2024
6 checks passed
@samuelim01 samuelim01 deleted the collab-page-repair-1 branch November 8, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelim01 samuelim01 samuelim01 approved these changes

@limcaaarl limcaaarl Awaiting requested review from limcaaarl

Assignees

@KhoonSun47 KhoonSun47

Labels
bug Something isn't working priority.Medium service.Collaboration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KhoonSun47 @samuelim01