Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#30 : Add bio list tests #103

Merged
merged 10 commits into from
Jul 21, 2020
Merged

Conversation

graemevissers
Copy link
Contributor

Add unit tests to BioList testList in BioCollectionsTests module

Changes

Add testCases:

  • isEqual
  • toString
  • toMonoIsotopicMass
  • toAverageMass
  • toMonoIsotopicMassWith
  • toAverageMassWith
  • toCompositionVector

to testList BioArray in BioCollectionsTests module.

Additionally, I changed "BioList.ofBioArray" to "List.ofArray" on previous unit tests to remove dependence of additional BioList functions.

Description

This contribution adds seven unit tests for BioList in the the BioCollectionsTests module. It also changes six previous unit tests to remove dependency on additional BioList functions.

[Required] please make sure you checked that

  • The project builds without problems on your machine

@kMutagene kMutagene changed the title Add bio list tests #30: Add bio list tests Jul 21, 2020
@kMutagene kMutagene changed the title #30: Add bio list tests #30 : Add bio list tests Jul 21, 2020
@kMutagene
Copy link
Member

Cool! Nothing to add here this time codewise. Next time it would be cool if you could reference the unit test issue in the title (which will cause this PR to be listed in its references) like this: #30

@kMutagene kMutagene merged commit 92060ff into CSBiology:developer Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants