Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Minimal assumption parser based on Discriminated Unions #5

Closed
omaus opened this issue Jul 27, 2023 · 1 comment
Closed

[Feature Request] Minimal assumption parser based on Discriminated Unions #5

omaus opened this issue Jul 27, 2023 · 1 comment
Assignees
@omaus

Comments

@omaus
Copy link
Member

omaus commented Jul 27, 2023

Current parser reads an OBO file and returns OboOntology type which consists of fields OboTerms which is a list of OboTerms and OboTypeDefs, a list of OboTypeDefs.
This means, the parser already creates a type that is split into components.

It might be better to have the minimal assumption, a Discriminated Union, first, and the OboOntology type later.
@omaus omaus self-assigned this Jul 27, 2023
omaus added a commit that referenced this issue Jul 28, 2023
@omaus
Merge pull request #9 from CSBiology/feature-minimalParser-#5
63512c8 
#5 Minimal parser
@omaus
Copy link
Member Author

omaus commented Jul 28, 2023

Done via #9.

@omaus omaus closed this as completed Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@omaus omaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@omaus