Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

prevent cookie toast duplicates #271 #288

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Conversation

teemukataja
Copy link
Contributor

Description

Previous change in #287 didn't actually fix the issue, the queue only hid the duplicates temporarily. Now when the toast is shown for the first time, a cookie is created to signify this event, so that a duplicate toast is not created again when changing views.

Related issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  • new cookie generated and checked when spawning toast

@teemukataja teemukataja added the bug Something isn't working label Dec 9, 2021
@teemukataja teemukataja requested a review from blankdots December 9, 2021 11:53
@teemukataja teemukataja self-assigned this Dec 9, 2021
@teemukataja teemukataja merged commit 249812c into dev Dec 9, 2021
@teemukataja teemukataja deleted the bug/duplicate-cookie-toasts branch December 9, 2021 12:18
@teemukataja teemukataja mentioned this pull request Dec 9, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants