Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily pin xclim below 0.29.0 #133

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Temporarily pin xclim below 0.29.0 #133

merged 1 commit into from
Aug 31, 2021

Conversation

Zeitsperre
Copy link
Member

Opening this PR to give us some wiggle room in case #132 requires a fair amount of effort.

@Zeitsperre Zeitsperre added the invalid This doesn't seem right label Aug 30, 2021
@Zeitsperre Zeitsperre requested a review from huard August 30, 2021 20:06
@Zeitsperre Zeitsperre self-assigned this Aug 30, 2021
huard
huard approved these changes Aug 31, 2021
View reviewed changes
Copy link
Collaborator

@huard huard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, I think it's good that we do not require RavenPy users to update so soon to the new xclim.

@Zeitsperre Zeitsperre marked this pull request as ready for review August 31, 2021 13:33
@Zeitsperre Zeitsperre merged commit 40c6a8f into master Aug 31, 2021
@Zeitsperre Zeitsperre deleted the xclim_029 branch August 31, 2021 13:33
tlvu added a commit to Ouranosinc/PAVICS-e2e-workflow-tests that referenced this pull request Sep 3, 2021
@tlvu
docker: temporary pin xclim and climpred for ravenpy
b37b800 
See CSHS-CWRA/RavenPy#134 and
CSHS-CWRA/RavenPy#133.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huard huard huard approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @huard