Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Notebooks 03 and 04 #319

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Updated Notebooks 03 and 04 #319

merged 3 commits into from
Oct 24, 2023

Conversation

richardarsenault
Copy link
Collaborator

Removed the multi-gauge code example. We will use a single netcdf file combining all variables in our tutorial examples to keep things simpler and avoir errors such as the tmax/tmin variables unable to compute t_avg when separated.

Removed documentation in the tutorials about 1-variable-per-gauge as it was causing problems with Temp_max and Temp_min being separated and not being able to calculate Temp_ave, whereas having all variables in the same netcdf file did allow so. To prevent further similar issues and let Raven parse correctly, this has been modified in notebooks 03 and 04, i.e. when generating the files and when using them to emulate hydrological models
@coveralls
Copy link

coveralls commented Oct 24, 2023

Pull Request Test Coverage Report for Build 6620966661

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 81.16%

Files with Coverage Reduction New Missed Lines %
ravenpy/config/parsers.py 1 74.67%
ravenpy/ravenpy.py 3 86.39%
Totals Coverage Status
Change from base Build 6617263106: -0.1%
Covered Lines: 3317
Relevant Lines: 4087

💛 - Coveralls

@huard huard merged commit 3507455 into master Oct 24, 2023
16 checks passed
@huard huard deleted the update_nb branch October 24, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants