Open raven-hydro pin #351
Merged
Open raven-hydro pin #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
raven-hydro >=0.2.4,<1.0is now the supported version of the model package.Additional information
It is very important that the upper pin is placed on
raven-hydroas we have older/obsolete versions in conda-forge that were pinned to the versions ofRavenHydroFramework. We dropped this convention in order to have more granular control over the version string.It's unclear to me how we can fix this versioning on conda-forge without breaking older packages, but it should be mentioned that the older packages of
RavenPyare broken anyway (the build-engine based onsetuptoolsrelied on direct downloads of the model source code using URLs that are no longer valid; i.e. we can no longer install the older versions ofRavenPyfrompip).