Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to raven-hydro v0.3.1 (RHF 3.8.1), drop Python3.8 conventions, address warnings #378

Merged
merged 17 commits into from
Jun 20, 2024

Conversation

Zeitsperre
Copy link
Member

@Zeitsperre Zeitsperre commented Jun 18, 2024

Changes

  • Updates the raven-hydro package to v0.3.1 (RavenHydroFramework v3.8.1)
  • Synchronizes several dependencies between pyproject.toml, environment*.yml, and tox.ini
  • Drops the code formatting conventions for Python3.8
  • Pins numpy below v2.0
  • Addresses a bunch of small warnings in the pytest output

Other information

This new build of raven-hydro will install on macOS systems using x86_64 or ARM64 architectures, but it does not seem to work for some reason (FYI @julemai; see: CSHS-CWRA/RavenHydroFramework#35).

@Zeitsperre Zeitsperre requested a review from huard June 18, 2024 14:59
@Zeitsperre Zeitsperre self-assigned this Jun 18, 2024
@coveralls
Copy link

Coverage Status

coverage: 81.87% (+0.1%) from 81.773%
when pulling 7b6e88f on raven-hydro-031
into 731a6cb on master.

@coveralls
Copy link

Coverage Status

coverage: 81.752% (-0.02%) from 81.773%
when pulling 0ea23c7 on raven-hydro-031
into 731a6cb on master.

@coveralls
Copy link

Coverage Status

coverage: 81.752% (-0.02%) from 81.773%
when pulling 3294b0e on raven-hydro-031
into 731a6cb on master.

@coveralls
Copy link

Coverage Status

coverage: 81.752% (-0.02%) from 81.773%
when pulling 6c9702e on raven-hydro-031
into 731a6cb on master.

@Zeitsperre Zeitsperre changed the title Update to raven-hydro v0.3.1 (RHF 3.8.1), drop Python3.8 conventions Update to raven-hydro v0.3.1 (RHF 3.8.1), drop Python3.8 conventions, address warnings Jun 18, 2024
@coveralls
Copy link

Coverage Status

coverage: 81.752% (-0.02%) from 81.773%
when pulling 6c9702e on raven-hydro-031
into 731a6cb on master.

tests/test_calibration.py Show resolved Hide resolved
Fixes #371 

TODO: review dependencies to make raven_hydro a "soft" dependency ?
@Zeitsperre Zeitsperre linked an issue Jun 20, 2024 that may be closed by this pull request
@coveralls
Copy link

Coverage Status

coverage: 81.846% (+0.07%) from 81.773%
when pulling 8b47515 on raven-hydro-031
into 731a6cb on master.

@Zeitsperre Zeitsperre merged commit cde004d into master Jun 20, 2024
14 checks passed
@Zeitsperre Zeitsperre deleted the raven-hydro-031 branch June 20, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't "pip install ravenpy[gis]" on ARM-based Mac architectures
3 participants