Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routing_product.py #401

Merged
merged 9 commits into from
Oct 2, 2024
Merged

Update routing_product.py #401

merged 9 commits into from
Oct 2, 2024

Commits on Sep 30, 2024

  1. Update routing_product.py

    Modified routing_product.py to correctly set the river length to zero and set default values for reach attributes in sub-basins with no channel routing (i.e., sub-basins with lakes or headwater basins).
    lou-a committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    80b9d95 View commit details
    Browse the repository at this point in the history
  2. Update routing_product.py

    Modified routing_product.py to correctly set the river length to zero and set default values for reach attributes in sub-basins with no channel routing (i.e., sub-basins with lakes or headwater basins).
    lou-a authored and Zeitsperre committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    31bd68d View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Apply suggestions from code review

    Co-authored-by: David Huard <huard.david@ouranos.ca>
    lou-a and huard authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0a06ed3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2e53462 View commit details
    Browse the repository at this point in the history
  3. Updated the change log, added contributor information and included tests

    Added a note in the CHANGELOG.rst, added contributor information in the .zenodo.json and in the AUTHORS.rst files, and added tests in the test_extractor.py script to confirm that everything is working as I expect.
    lou-a committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    0b11267 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f6575d9 View commit details
    Browse the repository at this point in the history
  5. Update .zenodo.json

    lou-a authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a07dbaa View commit details
    Browse the repository at this point in the history
  6. Update CHANGELOG.rst

    lou-a authored Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1d767db View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    74a6bd3 View commit details
    Browse the repository at this point in the history