Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: reset conversation only to top of step #179

Merged
merged 2 commits into from
Jan 19, 2021
Merged

imp: reset conversation only to top of step #179

merged 2 commits into from
Jan 19, 2021

Conversation

amerelo
Copy link
Member

@amerelo amerelo commented Jan 13, 2021

Fixes #178

Proposed Changes

  • if step code change for users in hold then the conversation rest at the start of the flow
  • If step doesn't exist any more then the user conversation is reset at flow start

@frsechet
Copy link
Member

frsechet commented Jan 16, 2021 •
edited
Loading

@amerelo please rebase after #156 is merged to remove all unnecessary commits + fix conflicts then ping me for tests 🙂

@amerelo amerelo marked this pull request as ready for review January 19, 2021 10:39
@amerelo amerelo force-pushed the update/conversation_reset_at_step branch from 65668b3 to da98700 Compare January 19, 2021 10:57
@amerelo amerelo force-pushed the update/conversation_reset_at_step branch from da98700 to 0f51561 Compare January 19, 2021 16:03
frsechet
frsechet reviewed Jan 19, 2021
View reviewed changes
csml_interpreter/examples/event.rs Show resolved Hide resolved
csml_interpreter/examples/factorial.rs Show resolved Hide resolved
csml_interpreter/examples/hello_world.rs Show resolved Hide resolved
csml_interpreter/examples/memory.rs Show resolved Hide resolved
csml_interpreter/examples/metadata.rs Show resolved Hide resolved
@frsechet frsechet changed the title Update/conversation reset at step imp: reset conversation only to top of step Jan 19, 2021
@frsechet frsechet merged commit c7c73f7 into master Jan 19, 2021
@frsechet frsechet deleted the update/conversation_reset_at_step branch January 19, 2021 21:41
@frsechet frsechet added this to the v1.4.0 milestone Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frsechet frsechet frsechet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Conversation reset at step
2 participants
@amerelo @frsechet