Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support client-side caching of schedules #613

Merged
merged 3 commits into from
Jul 24, 2021
Merged

Support client-side caching of schedules #613

merged 3 commits into from
Jul 24, 2021

Conversation

stefanor
Copy link
Member

Store a schedule version in the cache, and handle conditional HTTP requests for schedule views.

hodgestar
hodgestar approved these changes Jul 24, 2021
View reviewed changes
Copy link
Member

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be slightly odd to have the schedule version change whenever the cache goes away, but anything else would be more complicated.

+1 on merging.

@stefanor stefanor merged commit b878758 into master Jul 24, 2021
@stefanor stefanor deleted the schedule-caching branch July 24, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodgestar hodgestar hodgestar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanor @hodgestar