Force default to None if the list of allowed languages is empty #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the language list in settings is left at the default in the settings file, the default value in the database is set to '()', while the list of legal choices is empty. This results in the individual talk admin form being somewhat annoying to use, - unless the language field is explicitly deleted, the admin form will error out with "Select a valid choice. () is not one of the available choices." when a change is made.
This change sets the default to None in this case, which is more appropriate behaviour.
We could also change the default for WAFER_TALK_LANGUAGES to be None in the settings file, but there is value in keeping the hint that this should be a tuple there.