Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap registered / ticket info in it's own section #711

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

drnlm
Copy link
Member

@drnlm drnlm commented Jun 3, 2024

When the profile was refactored into snippets, the 'speaker isn't registered' block didn't get a surrounding <section>, unlike the other snippets.

This leads to the warning being rendered over the bio, rather than below it, which is undesirable. (This didn't happen previously, because stuff was in a common section)

This wraps stuff in it's own section, for consistency with the other snippets and to avoid the rendering issues.

@drnlm
Copy link
Member Author

drnlm commented Jun 3, 2024

git diff -w, for easier review

--- a/wafer/users/templates/wafer.users/snippets/profile_30-registered.html
+++ b/wafer/users/templates/wafer.users/snippets/profile_30-registered.html
@@ -3,6 +3,7 @@
   {% if can_edit %}
     {% if profile.pending_talks.exists or profile.accepted_talks.exists or profile.provisional_talks.e>
       {% block speaker_registered %}
+        <section class="wafer-profile-registered">
           {% if profile.is_registered %}
             <div class="alert alert-success">
               {% blocktrans trimmed %}
@@ -25,6 +26,7 @@
               {{ profile.ticket_types }}
             </p>
           {% endif %}
+        </section>
       {% endblock speaker_registered %}
     {% endif %}
   {% endif %}

@drnlm drnlm merged commit eb5f7d3 into CTPUG:master Jun 3, 2024
43 checks passed
@drnlm drnlm deleted the bugfix/wrap_warning_in_section branch July 8, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants