[CBRD-24453] Check the CCI driver file related to engine build. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://jira.cubrid.org/browse/CBRD-24453 - Change CCI Driver to use 'cascci.def' in 'cubrid-cci' repository cubrid/win/cascci.def -> cubrid/cubrid-cci/win/cascci.def - On build for engine, modify to use CCI BASE(cubic-cci/src/base) folder.
kisoo-han
approved these changes
Aug 12, 2022
airnet73
reviewed
Aug 16, 2022
| @@ -196,7 +196,7 @@ if(WIN32) | |||
| else(FOR_OTHER_DRIVER) | |||
| target_compile_definitions(cascci PRIVATE CAS_CCI_DL) | |||
| endif(FOR_OTHER_DRIVER) | |||
| set_target_properties(cascci PROPERTIES LINK_FLAGS "/DEF:\"${CMAKE_SOURCE_DIR}/win/cascci/cascci.def\"" LINK_FLAGS_RELEASE "/NODEFAULTLIB:libcmt.lib" LINK_FLAGS_DEBUG "/NODEFAULTLIB:msvcrt.lib") | |||
| set_target_properties(cascci PROPERTIES LINK_FLAGS "/DEF:\"${CCI_ROOT_PATH}/win/cascci/cascci.def\"" LINK_FLAGS_RELEASE "/NODEFAULTLIB:libcmt.lib" LINK_FLAGS_DEBUG "/NODEFAULTLIB:msvcrt.lib") | |||
There was a problem hiding this comment.
If CUBRID/win/cascci/cascci.def is no longer used, shouldn't it be deleted from the CUBRID repository?
There was a problem hiding this comment.
It will be deleted like remarks comment.
airnet73
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-24453
Purpose
Check the CCI driver file related to engine build.
Implementation
cubrid/win/cascci.def -> cubrid/cubrid-cci/win/cascci.def
Remarks
After the merge is completed, the file in engine Repository is also modified.