[TOOLS-4559] When exporting to local xls files, an error occurs if the data is large. #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e data is large. http://jira.cubrid.org/browse/TOOLS-4559 - If the data is large, it is displayed as blank and a list of errors is displayed in the 'no support' tab.
Srltas
reviewed
Feb 23, 2024
| @@ -0,0 +1,72 @@ | |||
| /* | |||
| * Copyright (C) 2009 Search Solution Corporation. All rights reserved by Search Solution. | |||
There was a problem hiding this comment.
Copyright needs to be modified to '2016 CUBRID Corporation'
There was a problem hiding this comment.
Thanks for the advice, fixed it.
| @@ -282,14 +284,25 @@ public int writeData( | |||
|
|
|||
| int index = 0; | |||
| for (String val : res) { | |||
| sheet.addCell(new jxl.write.Label(index++, total, val)); | |||
| if (val.length() > 32767) { | |||
There was a problem hiding this comment.
How about using a fixed constant value as a global variable?
ex) private static final int MAX_RECORD_LENGTH
There was a problem hiding this comment.
Thanks for the advice, fixed it. (MAX_EXCEL_CELL_LENGTH)
Srltas
approved these changes
Feb 23, 2024
kisoo-han
approved these changes
Feb 23, 2024
- constant definition
hwany7seo
added a commit
to hwany7seo/cubrid-migration
that referenced
this pull request
Feb 23, 2024
…e data is large. (CUBRID#142) http://jira.cubrid.org/browse/TOOLS-4559 - If the data is large, it is displayed as blank and a list of errors is displayed in the 'no support' tab.
hwany7seo
added a commit
that referenced
this pull request
Feb 27, 2024
…e data is large. (#142) (#148) http://jira.cubrid.org/browse/TOOLS-4559 - If the data is large, it is displayed as blank and a list of errors is displayed in the 'no support' tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/TOOLS-4559
Purpose
Implementation