[APIS-900] Add Autocommit mode to ODBC Data Source Setting window #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisoo-han
approved these changes
Feb 22, 2022
odbc_connection.c
Outdated
Comment on lines
821
to
823
| ut_tolower (autocommit); | ||
| pt = autocommit == NULL ? "on" : autocommit; | ||
| if (strcmp (autocommit, "on") == 0) |
There was a problem hiding this comment.
Suggestion: remove function ut_tolower () and use case independent string compare, _strcmp(), as other codes do, if it is possible.
pt = autocommit == NULL ? "on" : autocommit;
if (_strcmp (autocommit, "on") == 0)
There was a problem hiding this comment.
ut_tolower() is to compare the strings input in AUTOCOMMIT without case-sensitive.
Are you saying it should be case sensitive?
There was a problem hiding this comment.
_strcmp() is case insensitive string compare.
There was a problem hiding this comment.
My mistake it was
_stricmp ()
There was a problem hiding this comment.
pt = autocommit == NULL ? "on" : autocommit;
if (_stricmp (autocommit, "on") == 0)
|
It would be nice to pass the test build to the ERWIN for feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/APIS-900
Purpose
ODBC driver always works with autocommit=false. (Cannot be changed)
In this state, if more than 100 queries are performed in one transaction, an error occurs.To solve this problem, Autocommit mode should be added to the ODBC setting window so that the user can set it himself.
Error message:
[-830]Cannot allocate query entry any more. Maximum allocatable entries are 100
Implementation
N/A
Remarks
N/A