[APIS-936] Handle NULL pointer exception, TextLength2Ptr in SQLNativeSql #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisoo-han
changed the title
kisoo-han
changed the title
airnet73
reviewed
Oct 7, 2022
| @@ -1389,6 +1389,12 @@ SQLNativeSql (SQLHDBC ConnectionHandle, | |||
|
|
|||
| odbc_free_diag (((ODBC_CONNECTION *) ConnectionHandle)->diag, RESET); | |||
|
|
|||
| if (TextLength2Ptr == NULL) | |||
| { | |||
| odbc_set_diag (((ODBC_CONNECTION *) ConnectionHandle)->diag, "HY009", 0, "NULL pointer: TextLength2Ptr"); | |||
There was a problem hiding this comment.
How about ignoring if TextLength2Ptr is NULL?
There was a problem hiding this comment.
It would be better to just ignore it and return it. However, I want to keep the selection this time for the following reasons:
- A build of this fix has been sent to a customer and has already been verified, and if we make a change, we need to run this cycle again.
- There is no clear definition of this part in the definition of ODBC API. Your opinion may be more reasonable.
- A test case has already been written based on the error return.
- The choice of response to this error seems trivial.
Anyway, thanks for your comment.
airnet73
approved these changes
Oct 7, 2022
tw-kang
pushed a commit
that referenced
this pull request
Aug 22, 2023
Handle NULL pointer exception, SQLNativeSql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/APIS-936
Purpose
*TextLength2Ptr = length;Implementation
N/A
Remarks