Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOLS-4439] Update for TAB key handling #2

Merged
merged 5 commits into from
Mar 17, 2023

Conversation

kisoo-han
Copy link
Contributor

http://jira.cubrid.org/browse/TOOLS-4439

Purpose

  • csql modification requirements
  • modify libedit to output the tab key as it is

Implementation

Remarks
Currently, the list directory command is executed when the tab key is pressed twice.

@kisoo-han kisoo-han self-assigned this Mar 16, 2023
@kisoo-han kisoo-han requested review from mhoh3963 and airnet73 March 16, 2023 06:15
Copy link

@mhoh3963 mhoh3963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using #ifdef ~ #endif rather than removing the code ?

@kisoo-han
Copy link
Contributor Author

I will accept your proposal (use of if macro)

@kisoo-han kisoo-han requested a review from mhoh3963 March 17, 2023 03:35
@kisoo-han kisoo-han requested a review from mhoh3963 March 17, 2023 04:46
@kisoo-han kisoo-han merged commit 864f890 into CUBRID:master Mar 17, 2023
@kisoo-han kisoo-han deleted the tools-4439-insert-tab-asis branch March 17, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants