-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
亮度对比度增强功能存在显示问题,已找到问题并修改 #511
Comments
Hi, @thgpddl: Thank you very much for reporting the brightness and contrast enhancement display issue 🙏. The issue has been resolved by converting the image to RGB mode. Additionally, i have made some optimizations including adding a reset button 🔄. Please update to the latest version to see these improvements 🚀. |
感谢您的工作,但是现在遇到了新的问题,当我打开一个图片文件夹后,调整亮度对比度后,通过按键"D"打开下一张图片时程序闪退,并报错如下: TypeError: BrightnessContrastDialog.on_new_value() takes 1 positional argument but 2 were given
已放弃 (核心已转储) |
…ts and fixed TypeError in on_new_value method (#511)
Fixed. Please git pull the latest code and try to adjust the brightness and contrast again. 😄 |
在“视图”--“亮度对比度”功能中,修改亮度或对比度后,导致图像画面损坏,效果如下图:
![image](https://private-user-images.githubusercontent.com/48787805/346835679-865464d8-0988-4024-9469-960370d97fa5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyNjM1MTAsIm5iZiI6MTcyNDI2MzIxMCwicGF0aCI6Ii80ODc4NzgwNS8zNDY4MzU2NzktODY1NDY0ZDgtMDk4OC00MDI0LTk0NjktOTYwMzcwZDk3ZmE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIxVDE4MDAxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE4NzljYTVmMjNlYzExMTZmN2VjYjljODUyNWQyMGYxNDhhZDA1YjgwMjc4NDc4NjUyNGE2OTI4OTZiZDY3MWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.G44WUki0BQU4mlNAafklFiwH0rwf0pfplm4tsEIiBGg)
经过排查,是在“BrightnessContrastDialog”类的“on_new_value”函数中有问题:
解决办法为将PIL的RGBA模式转为RGB模式即可:
现在图像正常:
![image](https://private-user-images.githubusercontent.com/48787805/346837739-e5020bb6-f72d-4645-a6ef-da4467372ceb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyNjM1MTAsIm5iZiI6MTcyNDI2MzIxMCwicGF0aCI6Ii80ODc4NzgwNS8zNDY4Mzc3MzktZTUwMjBiYjYtZjcyZC00NjQ1LWE2ZWYtZGE0NDY3MzcyY2ViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIxVDE4MDAxMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWYzMjFjYjMwMmNlOTNlZTFlMmMxMzYxYmE5YzcyOGM5ZjY2MzMzZThkNWFhYTVlNjcyMzhjMmJlODExMDVlNDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.nS3tyg8nsLSgT9socapWCoSuS3Akvz6B2mSFmAcHzP0)
The text was updated successfully, but these errors were encountered: