-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add system_clipboard copy mode #485
Conversation
PairZhu
commented
Jun 30, 2024
- Refactor the code for serializing the Shape class
- Support for copying graphics using the system clipboard
By the way, the code for serializing the Shape class was refactored.
Since I do not have a compilation environment for Qt multilingual tools, I did not make a GUI configuration for this configuration item, if you think it is necessary, you can add it for me. |
@CVHub520 What about this PR |
@PairZhu, appreciate your contribution! I'd kindly ask you to rebase the pull request against the most recent main branch. After you've done that, I'll be ready to merge it in. Just to flag, the Shape struct has been updated with additional fields, including kie_linking, so please take these into account. Additionally, watch out for any other modifications that have been made. If you can push the updates today, I'll make sure to review and merge them promptly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All checks passed, LGTM!
Not finished yet |
Hey @PairZhu, I realized that I accidentally merged your PR even though it wasn't fully completed yet. I've rolled back the merge to prevent any issues. Could you please either create a new PR based on the updated branch or make the necessary modifications to the existing PR, ensuring that all the work is fully done? Thanks a lot for your understanding and cooperation. |
Don't worry, I just haven't added the corresponding action yet. |
That sounds great. If you have the time, would you mind completing it and then resubmitting the changes? Thank you once again for your generous contribution! |