Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSP_Config - Expand Functionality to Allow Passing of Internal Strings and Values Separately #63

Closed
CW-Khristos opened this issue Feb 28, 2020 · 1 comment
Closed

MSP_Config - Expand Functionality to Allow Passing of Internal Strings and Values Separately #63

CW-Khristos opened this issue Feb 28, 2020 · 1 comment
Assignees
@CW-Khristos @CW-Jonathan
Labels
enhancement New feature or request MSP Backups Items Related to MSP Backups MSP_Config Items Related to MSP_Config Script Protection Plans Items Related to Protection Plans validated Scripts Validated to be Functional

Comments

@CW-Khristos
Copy link
Owner

Is your feature request related to a problem? Please describe.

  • MSP_Config will add "additional" Internal String settings if value is changed from what Scheduled Task is configured to set. Techs cannot effectively change the following; if needed, without possible conflicts :
  • BackupThreadsCount
  • SynchronizationThreadCount
  • RestoreDownloadThreadCount
  • IgnoreMissedScheduledBackup

Describe the solution you'd like

  • Allow Passing of Internal Strings and Values Separately; that way conditional checks can just check if the internal string is present, and modify 'config.ini' only if it is not
  • Alternately; a 'force' option should be allowed to overwrite current Internal String Value

Describe alternatives you've considered

  • N/A

Additional context

  • N/A
@CW-Khristos CW-Khristos self-assigned this Feb 28, 2020
@CW-Khristos CW-Khristos added bug Something isn't working enhancement New feature or request MSP Backups Items Related to MSP Backups MSP_Config Items Related to MSP_Config Script needs validation Needs testing and validation PRIORITY Priority Items Protection Plans Items Related to Protection Plans labels Feb 28, 2020
@CW-Khristos CW-Khristos pinned this issue Feb 28, 2020
CW-Khristos added a commit that referenced this issue Feb 28, 2020
@CW-Khristos
MSP_Config, REF #2 , REF #63
aa234ac 
MSP_Config, REF #2 , REF #63
 - Changed 'strVER' Script Version from 3 to 4
 - Added string 'strVAL' for passing of Value to set
 - Added boolean 'blnFORCE' to control forcing of modification of Values for Internal Strings
 - Modified parsing of 'config.ini' to allow identification of Internal String already present in 'config.ini'
 - Modified parsing of 'config.ini' to check current Internal String Value to passed 'strVAL' Value
 - Script will only modify 'config.ini' if  Internal String is not found (will add to end of 'config.ini') or if Internal String is present, the set Value does not match AND the 'blnFORCE' flag is set to 'true'

version.xml, REF #2 , REF #63
 - Changed 'MSP_Config.vbs' Script Version from 3 to 4

@CW-Khristos @CW-Jonathan @rambopfc
@CW-Khristos
Copy link
Owner Author

MSP_Config, REF #2 , FIXES #63

Issue Resolved in Commit : aa234ac

@CW-Khristos CW-Khristos added validated Scripts Validated to be Functional and removed PRIORITY Priority Items bug Something isn't working needs validation Needs testing and validation labels Mar 3, 2020
@CW-Khristos CW-Khristos unpinned this issue Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CW-Khristos CW-Khristos

@CW-Jonathan CW-Jonathan

Labels
enhancement New feature or request MSP Backups Items Related to MSP Backups MSP_Config Items Related to MSP_Config Script Protection Plans Items Related to Protection Plans validated Scripts Validated to be Functional
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CW-Khristos @CW-Jonathan