Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tranceiver #131

Merged
merged 22 commits into from
Mar 23, 2024
Merged

Add tranceiver #131

merged 22 commits into from
Mar 23, 2024

Conversation

ShannonGriswold
Copy link
Contributor

Pull Request

What type of PR is this?

Migration from rov-23

Description

Moved over Arduino and Python code for the float from rov-23

Related Tickets & Documents

Copy link
Member

@InvincibleRMC InvincibleRMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add docstrings to functions.

namespace='surface',
package='transceiver',
executable='serial',
remappings=[("transceiver_control", "gui/transceiver_control"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe these remappings are required.

src/surface/transceiver/test/test_pep257.py Show resolved Hide resolved
@@ -0,0 +1 @@
sudo usermod -a -G dialout $USER
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the template please.

msg = FloatCommand()
msg.command = self.ser.readline().decode()
self.publisher.publish(msg)
# self.get_logger().info('Publishing: "%s"' % msg.data)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comment?

<depend>rclpy</depend>
<depend>sensor_msgs</depend>

<exec_depend>interfaces</exec_depend>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove interfaces

@@ -22,6 +23,11 @@ def __init__(self) -> None:

task_selector = TaskSelector()
main_layout.addWidget(task_selector, 1, 1)
self.task_selector: TaskSelector = TaskSelector()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete dupe

Copy link
Member

@InvincibleRMC InvincibleRMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShannonGriswold ShannonGriswold merged commit f6840d4 into main Mar 23, 2024
1 check passed
@ShannonGriswold ShannonGriswold deleted the add-tranceiver branch March 23, 2024 20:00
NoahMollerstuen pushed a commit that referenced this pull request May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update float code to use code from tranceiver branch of rov-23
2 participants