-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tranceiver #131
Add tranceiver #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add docstrings to functions.
namespace='surface', | ||
package='transceiver', | ||
executable='serial', | ||
remappings=[("transceiver_control", "gui/transceiver_control"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe these remappings are required.
@@ -0,0 +1 @@ | |||
sudo usermod -a -G dialout $USER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the template please.
msg = FloatCommand() | ||
msg.command = self.ser.readline().decode() | ||
self.publisher.publish(msg) | ||
# self.get_logger().info('Publishing: "%s"' % msg.data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comment?
src/surface/transceiver/package.xml
Outdated
<depend>rclpy</depend> | ||
<depend>sensor_msgs</depend> | ||
|
||
<exec_depend>interfaces</exec_depend> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove interfaces
src/surface/gui/gui/operator_app.py
Outdated
@@ -22,6 +23,11 @@ def __init__(self) -> None: | |||
|
|||
task_selector = TaskSelector() | |||
main_layout.addWidget(task_selector, 1, 1) | |||
self.task_selector: TaskSelector = TaskSelector() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete dupe
Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Pull Request
What type of PR is this?
Migration from rov-23
Description
Moved over Arduino and Python code for the float from rov-23
Related Tickets & Documents