Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transceiver #148

Merged
merged 60 commits into from
May 25, 2024
Merged

Update transceiver #148

merged 60 commits into from
May 25, 2024

Conversation

benjaminwp18
Copy link
Contributor

Pull Request

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

@benjaminwp18 benjaminwp18 linked an issue Apr 25, 2024 that may be closed by this pull request
[FEATURE] Update transceiver code #133
Closed
InvincibleRMC
InvincibleRMC requested changes Apr 25, 2024
View reviewed changes
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/surface_transceiver/surface_transceiver.ino Outdated Show resolved Hide resolved
@InvincibleRMC InvincibleRMC mentioned this pull request May 7, 2024
Merged
5 tasks
@InvincibleRMC
Copy link
Member

I would also recommend started to look into what changes the linter wants.

@InvincibleRMC InvincibleRMC mentioned this pull request May 16, 2024
Merged
5 tasks
@benjaminwp18
Copy link
Contributor Author

Remove trailing semicolon from data list

InvincibleRMC
InvincibleRMC requested changes May 25, 2024
View reviewed changes
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
src/float/float_transceiver/float_transceiver.ino Outdated Show resolved Hide resolved
benjaminwp18 and others added 4 commits May 25, 2024 17:17
@benjaminwp18 @InvincibleRMC
Use uint8_t for currentStage
54d0279 
Co-authored-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com>
@benjaminwp18 @InvincibleRMC
Use uint8_t for profileNum
3283828 
Co-authored-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com>
@benjaminwp18 @InvincibleRMC
Use uint8_t for profileHalf
8111f61 
Co-authored-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com>
@benjaminwp18 @InvincibleRMC
Update comment
b4ae452 
Co-authored-by: Michael Carlstrom <36806982+InvincibleRMC@users.noreply.github.com>
InvincibleRMC
InvincibleRMC approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@InvincibleRMC InvincibleRMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benjaminwp18 benjaminwp18 merged commit fe9a4c5 into main May 25, 2024
1 check passed
@InvincibleRMC InvincibleRMC deleted the update-transceiver branch May 25, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InvincibleRMC InvincibleRMC InvincibleRMC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Update transceiver code
3 participants
@benjaminwp18 @InvincibleRMC @NoahMollerstuen