Use livesteam gui as pilot gui #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move flood warning to operator and add alarm sound :)
|
Oops I'm logged in as Michael |
benjaminwp18
requested changes
Jun 9, 2024
src/surface/gui/gui/operator_app.py
Outdated
There was a problem hiding this comment.
I added the IP & Heartbeat widgets to the main tab as well as the temp sensor in main
It'd be cool if they were still there
src/surface/gui/gui/pilot_app.py
Outdated
| @@ -141,16 +145,27 @@ def __init__(self) -> None: | |||
| main_layout.addLayout(video_layout) | |||
| main_layout.addLayout(make_bottom_bar()) | |||
|
|
|||
| def show_on_monitor(self, monitor_id: int) -> None: | |||
| def apply_monitor_config(self, gui_id: str) -> None: | |||
benjaminwp18
requested changes
Jun 9, 2024
src/surface/gui/gui/pilot_app.py
Outdated
| TWO_MONITOR_CONFIG = {GuiType.PILOT: None, GuiType.LIVESTREAM: 1} | ||
| THREE_MONITOR_CONFIG = {GuiType.PILOT: 2, GuiType.LIVESTREAM: 1} | ||
|
|
||
|
|
||
| def make_bottom_bar() -> QHBoxLayout: |
There was a problem hiding this comment.
Add docstring and move into PilotApp
| def show_on_monitor(self, monitor_id: int) -> None: | ||
| self.apply_monitor_config(gui_type) | ||
|
|
||
| def apply_monitor_config(self, gui_type: GuiType) -> None: |
Co-authored-by: Benjamin Poulin <90342856+benjaminwp18@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use livestream gui for pilot gui and move flood warning to operator gui. Add fun surprise to flood warning :)