Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker #45

Merged
merged 97 commits into from
Nov 11, 2023
Merged

Docker #45

merged 97 commits into from
Nov 11, 2023

Conversation

InvincibleRMC
Copy link
Member

Pull Request

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

After much pain it works.

  • Related Issue #
  • Closes #

@InvincibleRMC
starts rn
0ce928c
@InvincibleRMC
fixed entrypoint
6a50e82
@InvincibleRMC
test
40b7e67
@InvincibleRMC
removed .gitconfig
8c0224b
@InvincibleRMC
update version number
8f5921b
@InvincibleRMC
allows running of file
8e66fea
@InvincibleRMC
Merge branch 'docker' of github.com:cwruRobotics/rov-24 into docker
4a960f0
@InvincibleRMC
made one line build
e14948b
@InvincibleRMC
use proper ros2
f0bd05a
@InvincibleRMC
devcotainer
aef5d6b
@InvincibleRMC
pain
bd52497
@InvincibleRMC
added ROS extension :)
2b540f9
@InvincibleRMC
added flake8 into container
748986f
@InvincibleRMC
removed entry_point
6fd25c9
@InvincibleRMC
building
1e69d92
@InvincibleRMC
merge
c604d37
@InvincibleRMC
moved image to docker-compose
cd792e9
@InvincibleRMC
fixed oopsy
154ac2d
@InvincibleRMC
Merge branch 'docker' of github.com:cwruRobotics/rov-24 into docker
d5d0275
@InvincibleRMC
fix git?
5fa96dd
@InvincibleRMC
cleaner readme
18ea93f
@InvincibleRMC
stuff
e75549e
@InvincibleRMC
DISPLAY???
714be6c
@InvincibleRMC
Merge remote-tracking branch 'origin/main' into docker
7038292
@InvincibleRMC
got xserver stuff working
e1db5ec
@InvincibleRMC
commented out docker-compose
d35195a
@InvincibleRMC
submodules
29aeaf3
@InvincibleRMC
submodule fix?
a34992a
@InvincibleRMC
apparently apt-get better for scripts
ab05938
@InvincibleRMC
for now remove onBlank
3321adc
@InvincibleRMC InvincibleRMC added the enhancement New feature or request label Nov 4, 2023
@InvincibleRMC InvincibleRMC self-assigned this Nov 4, 2023
benjaminwp18
benjaminwp18 requested changes Nov 6, 2023
View reviewed changes
.devcontainer/linux/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/macos/devcontainer.json Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
.github/workflows/docker.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@benjaminwp18
Copy link
Contributor

Add a table of contents to the readme

benjaminwp18
benjaminwp18 approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@benjaminwp18 benjaminwp18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do testing from other tickets my boy

@InvincibleRMC InvincibleRMC merged commit 4d4dd87 into main Nov 11, 2023
@InvincibleRMC InvincibleRMC deleted the docker branch November 11, 2023 21:19
NoahMollerstuen pushed a commit that referenced this pull request May 18, 2024
@InvincibleRMC
Merge pull request #45 from cwruRobotics/docker
e9ff9c5 
Docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminwp18 benjaminwp18 benjaminwp18 approved these changes

Assignees

@InvincibleRMC InvincibleRMC

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InvincibleRMC @benjaminwp18 @Jia22k