Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flood Visualization #83

Merged
merged 31 commits into from
Jan 27, 2024
Merged

Flood Visualization #83

merged 31 commits into from
Jan 27, 2024

Conversation

Tazmania40
Copy link
Contributor

Pull Request

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Adds functionality that detects flooding on a ROS2 topic /flooding and displays that information on the pilot display as a red dot rather than the default green state. The functionality is latching until the GUI is reset, as afaik, there isn't really a reason where a flood would not cause a system reset of some kind...

Related Tickets & Documents

@Tazmania40 Tazmania40 added enhancement New feature or request python Pull requests that update Python code labels Dec 16, 2023
@Tazmania40 Tazmania40 added this to the Preseason Projects milestone Dec 16, 2023
InvincibleRMC
InvincibleRMC requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@InvincibleRMC InvincibleRMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add remapping for flooding topic and update README.md for gui package.

src/surface/gui/gui/widgets/flood_visual.py Outdated Show resolved Hide resolved
@InvincibleRMC
Copy link
Member

On linux the Qlabel of emojis does not seem to work. Surely there is some QShape thing that can be used as circles or something.

@Tazmania40
Copy link
Contributor Author

Appears emoji support is more spotty than I thought... There unfortunately isn't a good way to do a QShape as described, but I'll look into it further.

@InvincibleRMC
Copy link
Member

Appears emoji support is more spotty than I thought... There unfortunately isn't a good way to do a QShape as described, but I'll look into it further.

I think something from here might work.

https://likegeeks.com/pyqt5-drawing-tutorial/#Draw_a_circle

benjaminwp18
benjaminwp18 requested changes Jan 27, 2024
View reviewed changes
src/surface/gui/gui/widgets/flood_visual.py Outdated Show resolved Hide resolved
src/surface/gui/gui/widgets/flood_visual.py Outdated Show resolved Hide resolved
src/surface/gui/gui/widgets/flood_visual.py Outdated Show resolved Hide resolved
benjaminwp18
benjaminwp18 requested changes Jan 27, 2024
View reviewed changes
Copy link
Contributor

@benjaminwp18 benjaminwp18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename flood_visual.py to flood_warning.py to match new class name

@benjaminwp18 benjaminwp18 self-requested a review January 27, 2024 21:35
@Tazmania40 Tazmania40 merged commit 4477ed6 into main Jan 27, 2024
1 check passed
@Tazmania40 Tazmania40 deleted the flood-visuals branch January 27, 2024 21:41
NoahMollerstuen pushed a commit that referenced this pull request May 18, 2024
@Tazmania40
Merge pull request #83 from cwruRobotics/flood-visuals
98536d3 
Flood Visualization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminwp18 benjaminwp18 benjaminwp18 approved these changes

@InvincibleRMC InvincibleRMC Awaiting requested review from InvincibleRMC

Assignees

@Tazmania40 Tazmania40

Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
Preseason Projects
Development

Successfully merging this pull request may close these issues.

Flood Detection Visualization
3 participants
@Tazmania40 @InvincibleRMC @benjaminwp18