commit

CWRUbotix · Jul 3, 2024 · 4b552cf · 4b552cf
1 parent c000f62
commit 4b552cf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/.github/workflows/industrial_ci_action.yml b/.github/workflows/industrial_ci_action.yml
@@ -48,9 +48,6 @@ jobs:
           # Done to avoid permssion errors in the ros-industrial ci.
           DOCKER_RUN_OPTS: -u root
           ROS_REPO: ${{ matrix.ROS_REPO }}
-          # Install missing libxcb-cursor0 xvfb for PyQt unit testing
-          # https://pytest-qt.readthedocs.io/en/latest/troubleshooting.html
-          ADDITIONAL_DEBS: 'libxcb-cursor0 xvfb'
           # Crazy one liner for install python dependencies
           AFTER_INSTALL_TARGET_DEPENDENCIES_EMBED: 'pip install --upgrade pip && pip install /root/target_ws/src/rov-25 --user && rm -r /root/target_ws/src/rov-25/build'
           # Used for running our CI but don't necessarily want to run others failing unit tests (ej. ament_pep257)
@@ -65,9 +62,6 @@ jobs:
             # Done to avoid permssion errors in the ros-industrial ci.
             # DOCKER_RUN_OPTS: -u root
             ROS_REPO: ${{ matrix.ROS_REPO }}
-            # Install missing libxcb-cursor0 xvfb for PyQt unit testing
-            # https://pytest-qt.readthedocs.io/en/latest/troubleshooting.html
-            ADDITIONAL_DEBS: 'libxcb-cursor0 xvfb'
             # Crazy one liner for install python dependencies
             AFTER_INSTALL_TARGET_DEPENDENCIES_EMBED: 'pip install --upgrade pip && pip install /root/target_ws/src/rov-25 --user && rm -r /root/target_ws/src/rov-25/build'
             # Used for running our CI but don't necessarily want to run others failing unit tests (ej. ament_pep257)

diff --git a/src/surface/gui/package.xml b/src/surface/gui/package.xml
@@ -12,6 +12,9 @@
   <test_depend>ament_pep257</test_depend>
   <test_depend>python3-pytest</test_depend>
 
+  <!-- For CI gui-less testing -->
+  <test_depend>xvfb</test_depend>
+
   <exec_depend>ros2launch</exec_depend>
   <exec_depend>ros2run</exec_depend>
   <exec_depend>rov_msgs</exec_depend>