Merge pull request #262 from abryko/kswitch-curl-zones

kswitch: fix error handling of caascad-zones call
Caascad · Sep 27, 2021 · 779ec46 · 779ec46
2 parents 8e2ff0f + c3bce0e
commit 779ec46
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/pkgs/kswitch/default.nix b/pkgs/kswitch/default.nix
@@ -13,7 +13,7 @@
 
 stdenv.mkDerivation rec {
   pname = "kswitch";
-  version = "1.8.4";
+  version = "1.8.5";
 
   buildInputs = [ makeWrapper ];
   passAsFile = [ "buildCommand" ];

diff --git a/pkgs/kswitch/kswitch.sh b/pkgs/kswitch/kswitch.sh
@@ -383,8 +383,9 @@ refresh_zones_or_cache() {
 refresh_zones() {
     log_debug "Refreshing caascad-zones..."
     local httpCode
-    httpCode="$(curl -w "%{response_code}" --connect-timeout 2 -s -o "${CAASCAD_ZONES_FILE}.tmp" "${CAASCAD_ZONES_URL}")" || { [ "${httpCode}" != "200" ] && log-error "Refreshing caascad-zones failed!" && return 1; }
-    mv "${CAASCAD_ZONES_FILE}.tmp" "${CAASCAD_ZONES_FILE}" || { log-error "Unable to write ${CAASCAD_ZONES_FILE}" && return 1; }
+    httpCode="$(curl -w "%{response_code}" --connect-timeout 2 -s -o "${CAASCAD_ZONES_FILE}.tmp" "${CAASCAD_ZONES_URL}")"
+    [ "${httpCode}" != "200" ] && { log-error "Refreshing caascad-zones failed!"; return 1; }
+    mv "${CAASCAD_ZONES_FILE}.tmp" "${CAASCAD_ZONES_FILE}" || { log-error "Unable to write ${CAASCAD_ZONES_FILE}"; return 1; }
 }
 
 zone_exists() {
@@ -506,16 +507,16 @@ while (("$#")); do
         exit 1
         ;;
     *)
-        [ "$zone" != "" ] && (log-error "too much arguments" && usage && exit 1)
+        [ "$zone" != "" ] && { log-error "too much arguments"; usage; exit 1; }
         zone=$1
         shift
         ;;
     esac
 done
 
 exitNow=0
-[ "${cleanCache}" -eq 1 ] && clean_cache && exitNow=1
-[ "${forceUnlock}" -eq 1 ] && force_unlock && exitNow=1
+[ "${cleanCache}" -eq 1 ] && { clean_cache; exitNow=1; }
+[ "${forceUnlock}" -eq 1 ] && { force_unlock; exitNow=1; }
 [ "${exitNow}" -eq 1 ] && exit 0
 
 # Makes sure to use ~/.kube/config