_IocpProactor: Acquire lock in previously missed methods #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the same reason that recv(), send(), accept() and connect()
need to acquire the lock, all the other operations need to as well.
This also shows a design limitation in this approach w.r.t.
maintainability (silent failure when new operations are added);
it would be preferable to either reproduce the windows_events
implementation in its entirety, or use proxying via composition
to ensure methods not made thread-safe cannot be invoked.
Finally, the _poll implementation seems to have further issues:
it is not clear to me that the _stopped_serving handling is
thread-safe, _unregistered is not handled, and it seems
preferable not to hold the lock when calling
GetQueuedCompletionStatus. I restricted this pull request to
addressing the straight-forward omission of wrappers for
ease of review, however.