Skip to content

🧹 move umount partitions and zfs zpool export into gucc #133

🧹 move umount partitions and zfs zpool export into gucc

🧹 move umount partitions and zfs zpool export into gucc #133

Triggered via push July 5, 2024 13:54
Status Success
Total duration 3m 17s
Artifacts

checks.yml

on: push
cpp-linter
3m 5s
cpp-linter
Check C++ style
19s
Check C++ style
Fit to window
Zoom out
Zoom in

Annotations

10 errors, 2 warnings, and 1 notice
/src/config.cpp:7:32 [cppcoreguidelines-avoid-non-const-global-variables: src/config.cpp#L7
variable 's_config' is non-const and globally accessible, consider making it const
/src/config.cpp:11:14 [bugprone-exception-escape: src/config.cpp#L11
an exception may be thrown in function 'initialize' which should not throw exceptions
/src/config.cpp:11:14 [modernize-use-trailing-return-type: src/config.cpp#L11
use a trailing return type for this function
/src/config.cpp:52:12 [readability-implicit-bool-conversion: src/config.cpp#L52
implicit conversion 'std::unique_ptr<Config>::pointer' (aka 'Config *') -> bool
/src/disk.cpp:24:11 [misc-unused-alias-decls: src/disk.cpp#L24
namespace alias decl 'fs' is unused
/src/disk.cpp:141:26 [modernize-use-trailing-return-type: src/disk.cpp#L141
use a trailing return type for this function
/src/disk.cpp:146:22 [readability-identifier-length: src/disk.cpp#L146
variable name 'vg' is too short, expected at least 3 characters
/src/disk.cpp:155:6 [bugprone-exception-escape: src/disk.cpp#L155
an exception may be thrown in function 'zfs_auto_pres' which should not throw exceptions
/src/disk.cpp:155:6 [modernize-use-trailing-return-type: src/disk.cpp#L155
use a trailing return type for this function
/src/disk.cpp:177:6 [bugprone-exception-escape: src/disk.cpp#L177
an exception may be thrown in function 'zfs_create_zpool' which should not throw exceptions
Check C++ style
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
cpp-linter
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Run clang-format on src/tui.cpp: src/tui.cpp#L1
File src/tui.cpp does not conform to Custom style guidelines. (lines 986, 987)