chwd: Some cleanups #134
Merged
chwd: Some cleanups #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnepogodin
requested changes
Aug 20, 2024
We're not handling it properly right now
Right now we don't handle any devices other than PCI by default, so it's useless.
ventureoo
force-pushed
the
remove-non-free
branch
2 times, most recently
from
f5af940
to
6f1006e
Compare
ventureoo
force-pushed
the
remove-non-free
branch
from
6f1006e
to
2407344
Compare
vnepogodin
reviewed
Aug 21, 2024
ventureoo
force-pushed
the
remove-non-free
branch
from
93ad70b
to
05e83d2
Compare
ventureoo
force-pushed
the
remove-non-free
branch
from
05e83d2
to
463ee63
Compare
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: Removes nonfree option. In my opinion, this parameter does not make any sense anymore. For example we now have "open source Nvidia modules" as nonfree profile, so it doesn't really reflect much of the real meaning, because many drivers might be partially closed/opened. This also makes no practical sense, because if we want to install closed drivers, we just increase priority for corresponding profile which we already do.
chwddisplays the profile priority as the second column now.Commit 2: Removes options related to USB. We don't handle USB profiles right now, so this just doesn't work.
Commit 3: Removes
--is_nvidia_card. In my opinion this is easily accomplished via lspci:lspci -d “10de:*:030x”and it also probably won't be needed anymore with #133.