-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cacti 1.3.0 - Dev b94bf9c3 - Graph Unknown RRDtool Error and Segmentation fault (core dumped) after enabling Thold Threshold #5915
Comments
Click on the Cog and then the wrench and post the RRDtool graph syntax that you see. Run that from the command line and let us know the error. |
Hi @TheWitness, RRDtool version: RRDtool path: RRDtool CLI version:
RRDtool graph syntax:
Graph syntax executed from CLI in attachment. |
That should be rendering then. |
Downgrade to 1.8 and see if that does anything better. |
Or another thing you can do is change the version on the settings general to version 1.7+ and it will disable a feature that we're experimenting with in rrdtool. |
Make sure you log off and then back into cacti before you test graphs after you make that change. |
Downgraded to 1.8+ nothing changed. |
By downgrade to 1.7+ on General tab, with binary path |
Okay you should go back to the 1.9.0 binary and then attempt to do a backtrace of the rrd tool and then report that to Tobi Oetikers GitHub page for rrdtool. @netniV and @browniebraun, problems with the new feature hover. FYI. |
* This may correct the issue with RRDtool. Not sure yet.
I just made a change to #!/bin/sh
/bin/rm -rf cacti-develop
git clone -b develop https://github.com/cacti/cacti.git cacti-develop
/bin/cp -rpf cacti-develop/* cacti
chown -R apache:apache cacti
/bin/rm -rf cacti-develop |
Unless you are just doing a clean pull of course. |
I'm just doing a
Even by executing the script under my Ubuntu 24.04 LTS Server (the Apache user and group is www-data):
If try to going back to RRDtool 1.7.2.+ with 1.9.0 path The graph is displayed again
|
Opened an issue on RRDTool Github too. |
Change |
It's the graphv. Option that is crashing using a new option to include the data points on the command line output. |
Tobi will be asking for a lot more detail. He will for sure ask for a backtrace. |
Command executed with |
There is an option missing from the command. Let me look it up. |
The option is |
Ok, after adding option to graphv, it crashes:
|
It's that last line. I think the buffer for the legend is too small. Let Tobi know. @netniV, can you patch rrdtool? If you shorten that text format to 20 characters or so, I bet it won't crash any longer. |
Show the graph syntax with tholds enabled. I thought those tholds lines were hrules not lines... |
New Thold for Memory Usage created and same issue. If shorten the name under 20 characters, the issu persists: below Graph syntax:
Trying to execute from CLI:
Thold config: Graph syntax with Thold enabled:
|
I've put a temp fix in for the moment so others don't experience this while we figure out what is broken in RRDtool. |
I've created the following pull request to address this issue: oetiker/rrdtool-1.x#1269 |
Thank you for the support @TheWitness, I've sent the backtrace to Tobi. |
There is a real issue with the export logic. I've been 'playing' with it today, and though I can keep the tool from locking up, some of the data that comes back on the export is not right. Additionally, it get's worse when you use redirected standard in vs. just calling the tool with the command line. This is indicative of a major data corruption somewhere in rrdtool. I've prepared a new |
…-jsontime * This does not fix the bug in RRDtool, but with the patch delivered to Tobi, the RRDtool binary is not crashing any more for me. * In this fix, we will use shell_exec() in place of proc_open() for now and attempt up-to 5 times. If RRDtool crashes, the Cacti admin will get an Email stating as much as well.
This add's some additional logging and addresses one bogus return variable.
Hi @TheWitness I've issued a
How I can compile your patched rrdtool here: https://github.com/TheWitness/rrdtool-1.x ? |
Ok @TheWitness I've compiled your patched RRDtool:
time to test now! |
Yes. It's just a workaround for now though. |
I think I see the issue now although I'm not the guy that needs to be fixing this there's some better people to deal with it. It's a feature interaction issue. They recently introduced a feature to allow a line to be drawn as a constant. Unfortunately this export function thinks that it's a real line and it's offsetting into memory as if there's values to be returned. Unfortunately that line is a constant and not containing any data from the Rd file structure so it needs to be eliminated from the array of returned objects. Once that done offsetting into the data should be correct. I guess I need to explain this to Tobi. |
@TheWitness with compiled RRDtool patched by you, I see segfault in GUI but trying to execute from CLI, it works
same warn in cacti.log
the difference from before is that I also had the memory graph in segfault, while now with your patched RRDtool, it works! |
@morganfw, I just updated my rrdtool-1.x repo with the final solution. Data is good now. Going to let Tobi know. |
@TheWitness I've done a You are the man! |
After creating a new DS, then a new Graph from scratch, the following Warn are written to log:
If try to go to graph and enable Real-time, a pop-up with error 500 appear, and following error is written to log:
|
I knew something would break. I'll try to get to it this week, but I'm going to be out of time with no access to my lab. |
Did those files exist? I imagining that this is the problem. |
Okay, a few hours before heading to the airport. So, I've fixed this one:
|
Just about to commit something to correct this one:
|
This should catch the failed INFO calls.
I might want to do a backtrace on these failures too. |
This will help us figure out the source of the issues.
Okay, the backtrace is there now. Keep me posted. |
Deleted and recreated graph, clicked on real-time, below the logs:
|
Hi,
not sure if RRDtool, Cacti or Thold plugin related.
After create a new graph:
then enabling a Threshold in 'Console - Management - Graphs' by selecting Graph and Create Aggregate from Template, at next poller run, Graph going into error then in segmentation fault
If delete the Threshold, Graph works again.
The text was updated successfully, but these errors were encountered: