Add IP address to the login audit for successful logins #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No concerns from my side. |
TheWitness
approved these changes
Jun 19, 2024
|
This is also covered in my recent changes of the audit plugin |
TheWitness
pushed a commit
that referenced
this pull request
Jun 20, 2024
* log message unification - add ip address * update
This was referenced Jun 21, 2024
Closed
|
Totally, Cacti 1.3.x have 34 LOGIN logs. Thanks. |
|
@ddb4github thank you for reporting. It was quick fix, it seems that I overlooked it. I will revise it soon |
netniV
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request from the forum. I agree with that. My customers use the log analyzer and the IP address information is missing for successful logins.
If you are agree with that I will prepare the same for 1.3