Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix %ARGS% defaults. #295

Merged
merged 5 commits into from
May 6, 2017
Merged

Fix %ARGS% defaults. #295

merged 5 commits into from
May 6, 2017

Conversation

Innectic
Copy link
Member

@Innectic Innectic commented May 5, 2017

Fixes #247

What does this change?

This fixes the defaults for the %ARGS% target.

Requirements

  • Only PG-rated language used (code, commits, etc.)
  • Descriptive commit messages
  • Changes have been tested
  • Changes do not break any existing functionalities

@Innectic Innectic added this to the v0.4.1 milestone May 5, 2017
@Innectic Innectic requested a review from 2Cubed May 5, 2017 22:30
@Innectic
Copy link
Member Author

Innectic commented May 6, 2017

This is actually really broken, don't review yet

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 59.223% when pulling b46a7cd on fix/ARGS-defaults into 4df8373 on develop.

@2Cubed
Copy link
Member

2Cubed commented May 6, 2017

Sweet, +0.1% coverage! 😜

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 59.316% when pulling 3330095 on fix/ARGS-defaults into 51dcca6 on develop.

@Innectic Innectic merged commit d877093 into develop May 6, 2017
@Innectic Innectic deleted the fix/ARGS-defaults branch May 6, 2017 01:52
@Innectic Innectic mentioned this pull request May 6, 2017
Open
@2Cubed 2Cubed mentioned this pull request May 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2Cubed 2Cubed 2Cubed approved these changes

Assignees
No one assigned
Labels
enhancement handler
Projects
None yet
Milestone
v0.4.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Innectic @coveralls @2Cubed