-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement screenshots in show #1759
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1759 +/- ##
==========================================
+ Coverage 95.33% 95.62% +0.28%
==========================================
Files 28 28
Lines 6841 8137 +1296
Branches 1025 1305 +280
==========================================
+ Hits 6522 7781 +1259
- Misses 194 222 +28
- Partials 125 134 +9 ☔ View full report in Codecov by Sentry. |
I don't think so. I don't see such issues. |
I don't know if it makes a difference, but I'm on Debian 12 x84_64. |
Would you be able to provide a MRE? If there is nothing obvious, I'd still propose to merge this and add a note in the docs. |
I wonder if there is a timing aspect to it. I cannot reproduce the issue that I had yesterday. |
Interesting, did you use |
I believe I tried it both ways, but I know I started with |
OK, unless you are able to reproduce it, I propose to park it. I will add a note to the docs anyhow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adam-urbanczyk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @adam-urbanczyk , screenshots also working for me.
I had to implement something quickly for my slides, I think it'll be quite useful for others.
Note that offscreen rendering does not work in CI with the exception of mac - that's why the test is dummy.