Add callbacks for ftp downloads #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 90.23% 90.51% +0.28%
==========================================
Files 5 5
Lines 635 654 +19
==========================================
+ Hits 573 592 +19
Misses 62 62 ☔ View full report in Codecov by Sentry. |
samaloney
force-pushed
the
feat-ftp-callbacks
branch
from
5018a7e
to
d9b17fa
Compare
samaloney
force-pushed
the
feat-ftp-callbacks
branch
3 times, most recently
from
574a903
to
591bec0
Compare
|
Thanks a lot @samaloney 🚀 The windows test fail seems real? |
|
Yea I assumed since it didn't have the |
samaloney
force-pushed
the
feat-ftp-callbacks
branch
from
591bec0
to
be2123d
Compare
samaloney
force-pushed
the
feat-ftp-callbacks
branch
from
be2123d
to
ebffbc2
Compare
Cadair
approved these changes
Apr 8, 2024
| httpserver.serve_content( | ||
| "SIMPLE = T", headers={"Content-Disposition": "attachment; filename=testfile.fits"} | ||
| ) | ||
|
|
||
| def done_callback(filepath, url, error): | ||
| (Path(gettempdir()) / "callback.done").touch() | ||
| cb = MagicMock() |
There was a problem hiding this comment.
using magicmock for this is a great idea and one I wish I had thought of lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#127 didn't add the callback for ftp downloads this PR adds them.