Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core & FsLocalizationPlugin] Fixed CStringControl and FsLocalizationStringDatabase issues #172

Merged
merged 1 commit into from
Oct 15, 2022
Merged

[Core & FsLocalizationPlugin] Fixed CStringControl and FsLocalizationStringDatabase issues #172

merged 1 commit into from
Oct 15, 2022

Conversation

NM-20
Copy link
Contributor

@NM-20 NM-20 commented Oct 12, 2022

  • Fixed an issue where the CStringControl would only display the StringId of a localized string on initial load. This was caused by the lack of a ShowStringDisplay invocation in the TargetUpdated handler.
  • Fixed an issue where the FsLocalizationStringDatabase would always retrieve an uppercase version of a given StringId, which resulted in mixed-case StringIds being shown as invalid.

@CadeEvs CadeEvs merged commit e3dfa4f into CadeEvs:1.0.6.2 Oct 15, 2022
@NM-20 NM-20 deleted the cstringcontrol-fslocalizationdb-fixes branch October 16, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NM-20 @CadeEvs