[Plugins] Fixed platform launcher failing to run Steam games with mods #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should follow the CodingStandards, even if the original code didnt |
|
That is my bad, am used to keeping with whatever code style was used, I will go through it in a minute and change it to follow C# Standards |
|
I meant the standards cade put into a file in FrostyCore/CodingStandards |
|
Ah, I did miss that file (I believe it is not on branch 1.0.6.2), thank you for pointing it out, I will comb the file again. May I ask have .editorconfig been considered, since the project uses VS-2022? |
|
Diana made a pr for that #121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlatformLauncher plugin would get stuck waiting for the platform and/or game to launch and would fail to set env variable properly for Steam and Epic Games Store.
These changes make games in these platforms now launch reliably with mods, as well as adds an extra option to the plugin configuration just for user comfort.