Skip to content

Commit

Permalink
A couple of minor fixes
Browse files Browse the repository at this point in the history
- `--strip_components` flag to `tar` seems more portable when placed
  before the file argument
- use latest available GCC and avoid a couple of warnings about
  mismatching signedness of expected/actual arguments
  • Loading branch information
hrutvik committed Sep 8, 2024
1 parent 3b393da commit 4087218
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pure.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- name: Get build-essentials
run: |
apt update
apt install -y git build-essential gcc-10 libffi-dev wget mlton
apt install -y git build-essential gcc libffi-dev wget mlton
- name: Checkout Poly/ML
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion examples/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ download:

lib/cake.S:
wget -q https://github.com/cakeml/cakeml/releases/latest/download/cake-x64-64.tar.gz
@tar -zxf cake-x64-64.tar.gz --directory $(@D) cake-x64-64/$(@F) --strip-components 1
@tar -zxf cake-x64-64.tar.gz --directory $(@D) --strip-components 1 cake-x64-64/$(@F)
@rm cake-x64-64.tar.gz

clean:
Expand Down
2 changes: 1 addition & 1 deletion examples/lib/basis_ffi.c
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ void ffistdout (unsigned char *c, long clen, unsigned char *a, long alen) {
a[1] = 0;
}

void write_ret_string(unsigned char *a, long alen, unsigned char *str) {
void write_ret_string(unsigned char *a, long alen, char *str) {
int length = strlen(str);
if (length < 256 * 256 && length <= alen) {
a[0] = length % 256;
Expand Down

0 comments on commit 4087218

Please sign in to comment.