Skip to content

Commit

Permalink
Warn about built-in script limitations in the script creation dialog
Browse files Browse the repository at this point in the history
This partially addresses godotengine#31758.
  • Loading branch information
Calinou committed Apr 4, 2020
1 parent 3d0c633 commit ac210e1
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
9 changes: 9 additions & 0 deletions editor/script_create_dialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,8 @@ void ScriptCreateDialog::_update_dialog() {

// Is Script created or loaded from existing file?

builtin_warning_label->set_visible(is_built_in);

if (is_built_in) {
get_ok()->set_text(TTR("Create"));
parent_name->set_editable(true);
Expand Down Expand Up @@ -756,6 +758,13 @@ ScriptCreateDialog::ScriptCreateDialog() {
path_error_label = memnew(Label);
vb->add_child(path_error_label);

builtin_warning_label = memnew(Label);
builtin_warning_label->set_text(
TTR("Note: Built-in scripts have some limitations and can't be edited using an external editor."));
vb->add_child(builtin_warning_label);
builtin_warning_label->set_autowrap(true);
builtin_warning_label->hide();

status_panel = memnew(PanelContainer);
status_panel->set_h_size_flags(Control::SIZE_FILL);
status_panel->add_child(vb);
Expand Down
1 change: 1 addition & 0 deletions editor/script_create_dialog.h
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ class ScriptCreateDialog : public ConfirmationDialog {
LineEdit *class_name;
Label *error_label;
Label *path_error_label;
Label *builtin_warning_label;
PanelContainer *status_panel;
LineEdit *parent_name;
Button *parent_browse_button;
Expand Down

0 comments on commit ac210e1

Please sign in to comment.