Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSU extract_dir #1229

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Insulinocytus
Copy link
Contributor

@Insulinocytus Insulinocytus commented Sep 8, 2024

OSU migrated updater from Squirrel to Velopack since 2024.906.1
This caused the file path changed from /lib/net45 to /lib/app.
ppy/osu#29783 (comment)

❯ scoop install osulazer
Installing 'osulazer' (2024.906.2) [64bit] from 'games' bucket
Loading osulazer-2024.906.2-full.nupkg from cache.
Checking hash of osulazer-2024.906.2-full.nupkg ... ok.
Extracting osulazer-2024.906.2-full.nupkg ... Could not find 'net45'! (error 16)
発生場所 C:\****\Scoop\apps\scoop\current\lib\core.ps1:889 文字:9
+         throw "Could not find '$(fname $from)'! (error $($proc.ExitCo ...
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : OperationStopped: (Could not find 'net45'! (error 16):String) [], RuntimeException
    + FullyQualifiedErrorId : Could not find 'net45'! (error 16)

Copy link
Contributor

github-actions bot commented Sep 8, 2024

All changes look good.

Wait for review from human collaborators.

osulazer

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@Calinou Calinou added the bug Something isn't working label Sep 23, 2024
Copy link
Owner

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou Calinou merged commit 31fa555 into Calinou:master Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working review-needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants